Closed
Conversation
fs streams already have a closed property. This PR standardized it and brings it inline with rest of streams.
nodejs-github-bot
added
fs
Member
Author
|
@nodejs/streams |
ronag
commented
Jun 20, 2020
|
|
||
| process.on('exit', function() { | ||
| assert(!file.closed); | ||
| assert(file.closed); |
Member
Author
There was a problem hiding this comment.
brings this inline with autoDestroy enabled by default
ronag
commented
Jun 20, 2020
|
|
||
| process.on('exit', function() { | ||
| assert(!file.closed); | ||
| assert(file.closed); |
Member
Author
There was a problem hiding this comment.
brings this inline with autoDestroy enabled by default
Member
Author
|
Might want to consider making this semver-major due to the changes in fs. Not sure. |
ronag
commented
Jun 20, 2020
ronag
commented
Jun 20, 2020
addaleax
approved these changes
Jun 20, 2020
ronag
added
the
author ready
Member
Author
|
Needs a CI |
ronag
removed
the
author ready
tniessen
added
the
semver-minor
Member
|
At least semver-minor, I assume. |
Member
Author
|
Giving this more thought... I'm actually a little unsure about this PR... when is |
Member
Author
|
Unless someone has further comments on what I wrote above I think I'm going to close this until we have a better reason to add this property. |
Member
|
I would close this. |
Member
|
Closing, we can always re-open if we want |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs streams already have a closed property. This PR standardized
it and brings it inline with rest of streams.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes